Adding AR code repeat limit

[john-peterson]

Adding AR code repeat limit

Problem

An incorrect code will overwrite much memory and crash the process

F.e. this GALE01 code

17:52:053 Src\ActionReplay.cpp:241 I[ActionReplay]: Code Name: P1 - Invincible
17:52:054 Src\ActionReplay.cpp:241 I[ActionReplay]: Number of codes: 3
17:52:054 Src\ActionReplay.cpp:241 I[ActionReplay]: --- Running Code: 00084e6c 08000000 ---
17:52:055 Src\ActionReplay.cpp:241 I[ActionReplay]: Doing Normal Code 00000000
17:52:055 Src\ActionReplay.cpp:241 I[ActionReplay]: Subtype: 00000000
17:52:056 Src\ActionReplay.cpp:241 I[ActionReplay]: Doing Ram Write And Fill
17:52:056 Src\ActionReplay.cpp:241 I[ActionReplay]: Hardware Address: 80084e6c
17:52:056 Src\ActionReplay.cpp:241 I[ActionReplay]: Size: 00000000
17:52:057 Src\ActionReplay.cpp:241 I[ActionReplay]: 8-bit Write
17:52:057 Src\ActionReplay.cpp:241 I[ActionReplay]: --------
17:52:057 Src\ActionReplay.cpp:241 I[ActionReplay]: Repeat: 00080000
17:52:057 Src\ActionReplay.cpp:241 I[ActionReplay]: --------

Solution

Limit repeat to 0xffff because

• there's no correct code that has a higher repeat than that

Discussion

[03:13] @Sonicadvance1 JPeterson, Pull request #25, no

What's the reason that you oppose the change?

[03:32] @Sonicadvance1 JPeterson, Pull request #25, It's an artificial limitation. If someone has the wrong code in the database, an issue should instead be created to have that particular code rectified or removed