Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the recompilation viewer to always be updated #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

john-peterson
Copy link
Member

Changing the recompilation viewer to always be updated

Problem

When recompilation is inspected by

  • showing the "JIT block viewer" and "Code" panels
  • stepping
  • selecting code in "Code"

the recompilation code comparison is shown with "right click → PPC vs X 86"

This is inefficient because

  • it's unnecessary to require action for this

Solution

Changing the recompilation viewer to always be updated

Discussion

[22:07] @Sonicadvance1 JPeterson, What if I don't want to view PPC->X86?

The patch doesn't have an option to step or select a code row in the "Code" window without updating the "JIT block viewer" window because

  • there's no common scenario where it's meaningful

If the "JIT block viewer" window isn't enabled it isn't updated

[22:46] @Sonicadvance1 JPeterson, eh?

Is the argument less clear than it can be?

[22:56] @Sonicadvance1 JPeterson, The change makes it so the PPC->X86 view is always on right?

no the change is that it's always updated (if it's enabled)

rather than update on "right click → PPC vs X 86"

because it's more efficient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant