{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":26850443,"defaultBranch":"master","name":"rust-clippy","ownerLogin":"rust-lang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-19T07:49:21.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5430905?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714737342.0","currentOid":""},"activityList":{"items":[{"before":"28e887fe719ed8fdcf2047c2e587efcd25e4d62e","after":"436675b4772049a0ff535bd46d944689c90ed750","ref":"refs/heads/master","pushedAt":"2024-06-01T11:25:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12868 - VitalikButerinEth:master, r=llogiq\n\nchore: fix some comments\n\n fix some comments\n\n----\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325057569\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12868\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12868/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12868\">#12868</a> - VitalikButerinEth:master, r=llogiq"}},{"before":"5d15f5db196e0d9699be6303bf7ea1c386b8b7cd","after":"436675b4772049a0ff535bd46d944689c90ed750","ref":"refs/heads/auto","pushedAt":"2024-06-01T11:16:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12868 - VitalikButerinEth:master, r=llogiq\n\nchore: fix some comments\n\n fix some comments\n\n----\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325057569\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12868\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12868/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12868\">#12868</a> - VitalikButerinEth:master, r=llogiq"}},{"before":"28e887fe719ed8fdcf2047c2e587efcd25e4d62e","after":"5d15f5db196e0d9699be6303bf7ea1c386b8b7cd","ref":"refs/heads/auto","pushedAt":"2024-06-01T10:47:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12868 - VitalikButerinEth:master, r=llogiq\n\nchore: fix some comments\n\n fix some comments","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325057569\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12868\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12868/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12868\">#12868</a> - VitalikButerinEth:master, r=llogiq"}},{"before":"7e4a87d75c6c184508462f38abe9e1f5a5e2e8e7","after":"e8649cef85b280f2a50941d9af6c392de5a21830","ref":"refs/heads/gh-pages","pushedAt":"2024-05-31T16:53:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Manishearth","name":"Manish Goregaokar","path":"/Manishearth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1617736?s=80&v=4"},"commit":{"message":"Automatic deploy to GitHub Pages: 28e887fe719ed8fdcf2047c2e587efcd25e4d62e","shortMessageHtmlLink":"Automatic deploy to GitHub Pages: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/rust-lang/rust-clippy/commit/28e887fe719ed8fdcf2047c2e587efcd25e4d62e/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/commit/28e887fe719ed8fdcf2047c2e587efcd25e4d62e\"><tt>28e887f</tt></a>"}},{"before":"0b598b636bc90d571aec60569713adfeb86d7819","after":"28e887fe719ed8fdcf2047c2e587efcd25e4d62e","ref":"refs/heads/master","pushedAt":"2024-05-31T16:52:05.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12488 - Jacherr:issue-11525, r=llogiq\n\nDisable `indexing_slicing` for custom Index impls\n\nFixes https://github.com/rust-lang/rust-clippy/issues/11525\n\nDisables `indexing_slicing` for custom Index impls, specifically any implementations that also do not have a `get` method anywhere along the deref chain (so, for example, it still lints on Vec, which has its `get` method as part of the deref chain).\n\nThanks `@y21` for pointing me in the right direction with a couple of handy util functions for deref chain and inherent methods, saved a headache there!\n\nchangelog: FP: Disable `indexing_slicing` for custom Index impls","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2187481393\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12488\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12488/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12488\">#12488</a> - Jacherr:issue-11525, r=llogiq"}},{"before":"0b598b636bc90d571aec60569713adfeb86d7819","after":"28e887fe719ed8fdcf2047c2e587efcd25e4d62e","ref":"refs/heads/auto","pushedAt":"2024-05-31T16:42:51.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12488 - Jacherr:issue-11525, r=llogiq\n\nDisable `indexing_slicing` for custom Index impls\n\nFixes https://github.com/rust-lang/rust-clippy/issues/11525\n\nDisables `indexing_slicing` for custom Index impls, specifically any implementations that also do not have a `get` method anywhere along the deref chain (so, for example, it still lints on Vec, which has its `get` method as part of the deref chain).\n\nThanks `@y21` for pointing me in the right direction with a couple of handy util functions for deref chain and inherent methods, saved a headache there!\n\nchangelog: FP: Disable `indexing_slicing` for custom Index impls","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2187481393\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12488\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12488/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12488\">#12488</a> - Jacherr:issue-11525, r=llogiq"}},{"before":"e7efe4381af5ae065105f6fa8c30ae86e01d3d9a","after":"0b598b636bc90d571aec60569713adfeb86d7819","ref":"refs/heads/master","pushedAt":"2024-05-31T15:33:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12865 - J-ZhengLi:issue12853, r=y21\n\nfix [`redundant_closure`] suggesting incorrect code with `F: Fn()`\n\nfixes: #12853\n\n---\n\nchangelog: fix [`redundant_closure`] suggesting incorrect code with `F: Fn()`","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322680004\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12865\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12865/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12865\">#12865</a> - J-ZhengLi:issue12853, r=y21"}},{"before":"e7efe4381af5ae065105f6fa8c30ae86e01d3d9a","after":"0b598b636bc90d571aec60569713adfeb86d7819","ref":"refs/heads/auto","pushedAt":"2024-05-31T15:23:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12865 - J-ZhengLi:issue12853, r=y21\n\nfix [`redundant_closure`] suggesting incorrect code with `F: Fn()`\n\nfixes: #12853\n\n---\n\nchangelog: fix [`redundant_closure`] suggesting incorrect code with `F: Fn()`","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322680004\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12865\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12865/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12865\">#12865</a> - J-ZhengLi:issue12853, r=y21"}},{"before":"aa3c342b0902c22e52732c74f7d310a184ece629","after":"7e4a87d75c6c184508462f38abe9e1f5a5e2e8e7","ref":"refs/heads/gh-pages","pushedAt":"2024-05-30T16:11:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Manishearth","name":"Manish Goregaokar","path":"/Manishearth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1617736?s=80&v=4"},"commit":{"message":"Automatic deploy to GitHub Pages: e7efe4381af5ae065105f6fa8c30ae86e01d3d9a","shortMessageHtmlLink":"Automatic deploy to GitHub Pages: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/rust-lang/rust-clippy/commit/e7efe4381af5ae065105f6fa8c30ae86e01d3d9a/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/commit/e7efe4381af5ae065105f6fa8c30ae86e01d3d9a\"><tt>e7efe43</tt></a>"}},{"before":"03654badfd7221bd637daa7a214a0d73db176299","after":"e7efe4381af5ae065105f6fa8c30ae86e01d3d9a","ref":"refs/heads/master","pushedAt":"2024-05-30T16:09:10.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12857 - WeiTheShinobi:non_canonical_impls, r=y21\n\nfix: let non_canonical_impls skip proc marco\n\nFixed #12788\n\nAlthough the issue only mentions `NON_CANONICAL_CLONE_IMPL`, this fix will also affect `NON_CANONICAL_PARTIAL_ORD_IMPL` because I saw\n> Because of these unforeseeable or unstable behaviors, macro expansion should often not be regarded as a part of the stable API.\n\non Clippy Documentation and these two lints are similar, so I think it might be good, not sure if it's right or not.\n\n---\n\nchangelog: `NON_CANONICAL_CLONE_IMPL`, `NON_CANONICAL_PARTIAL_ORD_IMPL` will skip proc marco now","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317652065\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12857\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12857/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12857\">#12857</a> - WeiTheShinobi:non_canonical_impls, r=y21"}},{"before":"03654badfd7221bd637daa7a214a0d73db176299","after":"e7efe4381af5ae065105f6fa8c30ae86e01d3d9a","ref":"refs/heads/auto","pushedAt":"2024-05-30T15:58:49.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12857 - WeiTheShinobi:non_canonical_impls, r=y21\n\nfix: let non_canonical_impls skip proc marco\n\nFixed #12788\n\nAlthough the issue only mentions `NON_CANONICAL_CLONE_IMPL`, this fix will also affect `NON_CANONICAL_PARTIAL_ORD_IMPL` because I saw\n> Because of these unforeseeable or unstable behaviors, macro expansion should often not be regarded as a part of the stable API.\n\non Clippy Documentation and these two lints are similar, so I think it might be good, not sure if it's right or not.\n\n---\n\nchangelog: `NON_CANONICAL_CLONE_IMPL`, `NON_CANONICAL_PARTIAL_ORD_IMPL` will skip proc marco now","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317652065\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12857\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12857/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12857\">#12857</a> - WeiTheShinobi:non_canonical_impls, r=y21"}},{"before":"c9139bd546d9cd69df817faeab62c5f9b1a51337","after":"03654badfd7221bd637daa7a214a0d73db176299","ref":"refs/heads/master","pushedAt":"2024-05-30T10:26:15.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12864 - tesuji:non-no-effect, r=y21\n\nignore array from `deref_addrof` lint\n\nSplit from https://github.com/rust-lang/rust-clippy/pull/12854\n\nchangelog: ignore array from `deref_addrof` lint\n\nr? y21","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322222235\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12864\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12864/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12864\">#12864</a> - tesuji:non-no-effect, r=y21"}},{"before":"c9139bd546d9cd69df817faeab62c5f9b1a51337","after":"03654badfd7221bd637daa7a214a0d73db176299","ref":"refs/heads/auto","pushedAt":"2024-05-30T10:16:51.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12864 - tesuji:non-no-effect, r=y21\n\nignore array from `deref_addrof` lint\n\nSplit from https://github.com/rust-lang/rust-clippy/pull/12854\n\nchangelog: ignore array from `deref_addrof` lint\n\nr? y21","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322222235\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12864\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12864/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12864\">#12864</a> - tesuji:non-no-effect, r=y21"}},{"before":"da4b2127c0a144699b946eec3c8c9d4fd7050c17","after":"c9139bd546d9cd69df817faeab62c5f9b1a51337","ref":"refs/heads/master","pushedAt":"2024-05-30T08:26:16.000Z","pushType":"push","commitsCount":25,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12867 - flip1995:rustup, r=flip1995\n\nRustup\n\nr? `@ghost`\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2324949567\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12867\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12867/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12867\">#12867</a> - flip1995:rustup, r=flip1995"}},{"before":"28743b9266e35ccff3a67f26857636198d07fee1","after":"c9139bd546d9cd69df817faeab62c5f9b1a51337","ref":"refs/heads/auto","pushedAt":"2024-05-30T08:11:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12867 - flip1995:rustup, r=flip1995\n\nRustup\n\nr? `@ghost`\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2324949567\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12867\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12867/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12867\">#12867</a> - flip1995:rustup, r=flip1995"}},{"before":"da4b2127c0a144699b946eec3c8c9d4fd7050c17","after":"28743b9266e35ccff3a67f26857636198d07fee1","ref":"refs/heads/auto","pushedAt":"2024-05-30T07:50:30.000Z","pushType":"push","commitsCount":25,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12867 - flip1995:rustup, r=flip1995\n\nRustup\n\nr? `@ghost`\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2324949567\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12867\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12867/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12867\">#12867</a> - flip1995:rustup, r=flip1995"}},{"before":"76eee82e79e736c4cef6ee9f755f58e752b9f58a","after":"da4b2127c0a144699b946eec3c8c9d4fd7050c17","ref":"refs/heads/master","pushedAt":"2024-05-28T12:51:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12859 - cookie-s:dedup-single-char-name-diag, r=Alexendoo\n\n[`many_single_char_names`]: Deduplicate diagnostics\n\nRelates to #12379\n\nFix `many_single_char_names` lint so that it doesn't emit diagnostics when the current level of the scope doesn't contain any single character name.\n\n```rust\nlet (a, b, c, d): (i32, i32, i32, i32);\nmatch 1 {\n  1 => (),\n  e => {},\n}\n```\nproduced the exact same MANY_SINGLE_CHAR_NAMES diagnostic at each of the Arm `e => {}` and the Block `{}`.\n\n---\n\nchangelog: [`many_single_char_names`]: Fix duplicate diagnostics","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318119093\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12859\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12859/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12859\">#12859</a> - cookie-s:dedup-single-char-name-diag, r=Alexendoo"}},{"before":"76eee82e79e736c4cef6ee9f755f58e752b9f58a","after":"da4b2127c0a144699b946eec3c8c9d4fd7050c17","ref":"refs/heads/auto","pushedAt":"2024-05-28T12:41:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12859 - cookie-s:dedup-single-char-name-diag, r=Alexendoo\n\n[`many_single_char_names`]: Deduplicate diagnostics\n\nRelates to #12379\n\nFix `many_single_char_names` lint so that it doesn't emit diagnostics when the current level of the scope doesn't contain any single character name.\n\n```rust\nlet (a, b, c, d): (i32, i32, i32, i32);\nmatch 1 {\n  1 => (),\n  e => {},\n}\n```\nproduced the exact same MANY_SINGLE_CHAR_NAMES diagnostic at each of the Arm `e => {}` and the Block `{}`.\n\n---\n\nchangelog: [`many_single_char_names`]: Fix duplicate diagnostics","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318119093\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12859\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12859/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12859\">#12859</a> - cookie-s:dedup-single-char-name-diag, r=Alexendoo"}},{"before":"7e4c1ae0b6df9d498759ffec150c46f605adeb59","after":"76eee82e79e736c4cef6ee9f755f58e752b9f58a","ref":"refs/heads/master","pushedAt":"2024-05-27T16:27:53.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12823 - schvv31n:fix-iter-on-empty-collections, r=y21\n\nSuppress `iter_on_empty_collections` if the iterator's concrete type is relied upon\n\nchangelog: fixed #12807","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2304777797\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12823\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12823/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12823\">#12823</a> - schvv31n:fix-iter-on-empty-collections, r=y21"}},{"before":"7e4c1ae0b6df9d498759ffec150c46f605adeb59","after":"76eee82e79e736c4cef6ee9f755f58e752b9f58a","ref":"refs/heads/auto","pushedAt":"2024-05-27T16:18:42.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12823 - schvv31n:fix-iter-on-empty-collections, r=y21\n\nSuppress `iter_on_empty_collections` if the iterator's concrete type is relied upon\n\nchangelog: fixed #12807","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2304777797\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12823\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12823/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12823\">#12823</a> - schvv31n:fix-iter-on-empty-collections, r=y21"}},{"before":"20f0f135ee1fefa143cbe887471f9d9631f8f052","after":"7e4c1ae0b6df9d498759ffec150c46f605adeb59","ref":"refs/heads/master","pushedAt":"2024-05-27T14:36:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12843 - mdm:fix-unnecessary-to-owned-println-interaction, r=y21\n\nFix `unnecessary_to_owned` interaction with macro expansion\n\nfixes #12821\n\nIn the case of an unnecessary `.iter().cloned()`, the lint `unnecessary_to_owned` might suggest to remove the `&` from references without checking if such references are inside a macro expansion. This can lead to unexpected behavior or even broken code if the lint suggestion is applied blindly. See issue #12821 for an example.\n\nThis PR checks if such references are inside macro expansions and skips this part of the lint suggestion in these cases.\n\nchangelog: [`unnecessary_to_owned`]: Don't suggest to remove `&` inside macro expansion","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2315766793\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12843\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12843/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12843\">#12843</a> - mdm:fix-unnecessary-to-owned-println-interacti…"}},{"before":"20f0f135ee1fefa143cbe887471f9d9631f8f052","after":"7e4c1ae0b6df9d498759ffec150c46f605adeb59","ref":"refs/heads/auto","pushedAt":"2024-05-27T14:26:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12843 - mdm:fix-unnecessary-to-owned-println-interaction, r=y21\n\nFix `unnecessary_to_owned` interaction with macro expansion\n\nfixes #12821\n\nIn the case of an unnecessary `.iter().cloned()`, the lint `unnecessary_to_owned` might suggest to remove the `&` from references without checking if such references are inside a macro expansion. This can lead to unexpected behavior or even broken code if the lint suggestion is applied blindly. See issue #12821 for an example.\n\nThis PR checks if such references are inside macro expansions and skips this part of the lint suggestion in these cases.\n\nchangelog: [`unnecessary_to_owned`]: Don't suggest to remove `&` inside macro expansion","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2315766793\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12843\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12843/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12843\">#12843</a> - mdm:fix-unnecessary-to-owned-println-interacti…"}},{"before":"722de3b5462ab0efa4a89e39aa6a2adc61940dc0","after":"20f0f135ee1fefa143cbe887471f9d9631f8f052","ref":"refs/heads/master","pushedAt":"2024-05-27T10:28:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12852 - finga:master, r=flip1995\n\nbook: Fix example code\n\nFix example code of the \"Disabling evaluation of certain code\" section in the configuration chapter.\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317202230\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12852\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12852/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12852\">#12852</a> - finga:master, r=flip1995"}},{"before":"7f6c56a9cfd709addaaecc7429077c595a0ba414","after":"20f0f135ee1fefa143cbe887471f9d9631f8f052","ref":"refs/heads/auto","pushedAt":"2024-05-27T10:18:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12852 - finga:master, r=flip1995\n\nbook: Fix example code\n\nFix example code of the \"Disabling evaluation of certain code\" section in the configuration chapter.\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317202230\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12852\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12852/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12852\">#12852</a> - finga:master, r=flip1995"}},{"before":"154efcbae754711aea45a6f33d5412508401bb4a","after":"7f6c56a9cfd709addaaecc7429077c595a0ba414","ref":"refs/heads/auto","pushedAt":"2024-05-27T08:41:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12852 - finga:master, r=flip1995\n\nbook: Fix example code\n\nFix example code of the \"Disabling evaluation of certain code\" section in the configuration chapter.\n\nchangelog: none","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317202230\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12852\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12852/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12852\">#12852</a> - finga:master, r=flip1995"}},{"before":"4be463fe32038ccfa87e96b79d8528516f069fc7","after":"aa3c342b0902c22e52732c74f7d310a184ece629","ref":"refs/heads/gh-pages","pushedAt":"2024-05-27T08:15:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Manishearth","name":"Manish Goregaokar","path":"/Manishearth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1617736?s=80&v=4"},"commit":{"message":"Automatic deploy to GitHub Pages: 722de3b5462ab0efa4a89e39aa6a2adc61940dc0","shortMessageHtmlLink":"Automatic deploy to GitHub Pages: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/rust-lang/rust-clippy/commit/722de3b5462ab0efa4a89e39aa6a2adc61940dc0/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/commit/722de3b5462ab0efa4a89e39aa6a2adc61940dc0\"><tt>722de3b</tt></a>"}},{"before":"722de3b5462ab0efa4a89e39aa6a2adc61940dc0","after":"154efcbae754711aea45a6f33d5412508401bb4a","ref":"refs/heads/auto","pushedAt":"2024-05-27T08:14:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12852 - finga:master, r=flip1995\n\nbook: Fix example code\n\nFix example code of the \"Disabling evaluation of certain code\" section in the configuration chapter.","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317202230\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12852\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12852/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12852\">#12852</a> - finga:master, r=flip1995"}},{"before":"5aae5f6ae6b4ba0e6ddadea43e6a2bcadcaa2328","after":"722de3b5462ab0efa4a89e39aa6a2adc61940dc0","ref":"refs/heads/master","pushedAt":"2024-05-27T08:13:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12842 - J-ZhengLi:issue12801, r=y21\n\nadd parentheses to [`let_and_return`]'s suggestion\n\ncloses: #12801\n\n---\n\nchangelog: suggest adding parentheses when linting [`let_and_return`] and [`needless_return`]","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2314609622\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12842\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12842/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12842\">#12842</a> - J-ZhengLi:issue12801, r=y21"}},{"before":"5aae5f6ae6b4ba0e6ddadea43e6a2bcadcaa2328","after":"722de3b5462ab0efa4a89e39aa6a2adc61940dc0","ref":"refs/heads/auto","pushedAt":"2024-05-27T08:04:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12842 - J-ZhengLi:issue12801, r=y21\n\nadd parentheses to [`let_and_return`]'s suggestion\n\ncloses: #12801\n\n---\n\nchangelog: suggest adding parentheses when linting [`let_and_return`] and [`needless_return`]","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2314609622\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12842\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12842/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12842\">#12842</a> - J-ZhengLi:issue12801, r=y21"}},{"before":"5d10538fb4e3294cdb8d7b95fb0b3e5239598e3f","after":"5aae5f6ae6b4ba0e6ddadea43e6a2bcadcaa2328","ref":"refs/heads/master","pushedAt":"2024-05-25T13:21:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bors","name":"bors","path":"/bors","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3372342?s=80&v=4"},"commit":{"message":"Auto merge of #12740 - lrh2000:sig-drop, r=blyxyas\n\n`significant_drop_in_scrutinee`: Trigger lint only if lifetime allows early significant drop\n\nI want to argue that the following code snippet should not trigger `significant_drop_in_scrutinee` (https://github.com/rust-lang/rust-clippy/issues/8987). The iterator holds a reference to the locked data, so it is expected that the mutex guard must be alive until the entire loop is finished.\n```rust\nuse std::sync::Mutex;\n\nfn main() {\n    let mutex_vec = Mutex::new(vec![1, 2, 3]);\n    for number in mutex_vec.lock().unwrap().iter() {\n        dbg!(number);\n    }\n}\n```\n\nHowever, the lint should be triggered when we clone the vector. In this case, the iterator does not hold any reference to the locked data.\n```diff\n-     for number in mutex_vec.lock().unwrap().iter() {\n+     for number in mutex_vec.lock().unwrap().clone().iter() {\n```\n\nUnfortunately, it seems that regions on the types of local variables are mostly erased (`ReErased`) in the late lint pass. So it is hard to tell if the final expression has a lifetime relevant to the value with a significant drop.\n\nIn this PR, I try to make a best-effort guess based on the function signatures. To avoid false positives, no lint is issued if the result is uncertain. I'm not sure if this is acceptable or not, so any comments are welcome.\n\nFixes https://github.com/rust-lang/rust-clippy/issues/8987\n\nchangelog: [`significant_drop_in_scrutinee`]: Trigger lint only if lifetime allows early significant drop.\n\nr? `@flip1995`","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2271756457\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust-clippy/issues/12740\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust-clippy/pull/12740/hovercard\" href=\"https://github.com/rust-lang/rust-clippy/pull/12740\">#12740</a> - lrh2000:sig-drop, r=blyxyas"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWbFWsQA","startCursor":null,"endCursor":null}},"title":"Activity · rust-lang/rust-clippy"}